[Auto Parallel] fix bugs for split_batches_for_accumulation && fix bu… #9217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9217 +/- ##
===========================================
- Coverage 53.11% 52.74% -0.38%
===========================================
Files 665 661 -4
Lines 109041 107375 -1666
===========================================
- Hits 57918 56634 -1284
+ Misses 51123 50741 -382 ☔ View full report in Codecov by Sentry. |
zhangyuqin1998
force-pushed
the
fix_split_batches_for_accumulation
branch
from
fc375a4 to
225b3a7
Compare
…gs for enable_delay_scale_loss
zhangyuqin1998
force-pushed
the
fix_split_batches_for_accumulation
branch
from
225b3a7 to
513086c
Compare
From00
previously approved these changes
Oct 12, 2024
zhangyuqin1998
force-pushed
the
fix_split_batches_for_accumulation
branch
from
8981571 to
02f6d7d
Compare
zhangyuqin1998
force-pushed
the
fix_split_batches_for_accumulation
branch
from
cadd4d4 to
f286f90
Compare
lvdongyi
pushed a commit
to lvdongyi/PaddleNLP
that referenced
this pull request
Oct 23, 2024
PaddlePaddle#9217) * [Auto Parallel] fix bugs for split_batches_for_accumulation && fix bugs for enable_delay_scale_loss * add enable_delay_scale_loss flag for auto_parallel * fix ut * Update ci_case_auto.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gs for enable_delay_scale_loss
PR types
Bug fixes
PR changes
Others
Description
A.修复动态图自动并行下，split_batches_for_accumulation与动手无法对齐的情况。如图
B.修复动态图自动并行下，enable_delay_scale_loss逻辑错误的问题。自动并行默认实现enable_delay_scale_loss，预期行为为：
但当前动态图自动并行的行为为：
此外，由于enable_delay_scale_loss逻辑不完善，为自动并行增加开关
C. 修复静态图自动并行下，loss打印展示问题。loss预期的展示行为为：
但当前静态图自动并行loss对打印展示行为为：
D. 修复函数名称错误，将traning修正为training